Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3602)

Unified Diff: chromeos/tpm_token_loader.h

Issue 386593002: Update TPMTokenLoader class comment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/tpm_token_loader.h
diff --git a/chromeos/tpm_token_loader.h b/chromeos/tpm_token_loader.h
index 9ac7a61e61df4adfc9b5636c31771a2c35fcd190..80fbaa2c599ecd55c741ac609282c4017663c1ca 100644
--- a/chromeos/tpm_token_loader.h
+++ b/chromeos/tpm_token_loader.h
@@ -23,11 +23,13 @@ class SequencedTaskRunner;
namespace chromeos {
-// This class is responsible for loading the TPM token when the user logs
-// in. It is expected to be constructed on the UI thread and public methods
-// should all be called from the UI thread. When the TPM token is loaded,
-// or if the TPM should stay disabled for the session, the observers are
+// This class is responsible for loading the TPM backed token and system slot
stevenjb 2014/07/11 16:30:07 nit: 'setting the system slot'? I'm not super fami
+// when the user logs in. It is expected to be constructed on the UI thread and
+// public methods should all be called from the UI thread. When the TPM token is
+// loaded, or if the TPM should stay disabled for the session, the observers are
// notified using |OnTPMTokenReady|.
+// Note: This currently loads the hard coded default slot with id 0. See
stevenjb 2014/07/11 16:30:07 Also here, "sets the hard coded default slot to id
pneubeck (no reviews) 2014/07/12 09:48:14 Yeah, the crypto nomenclature takes getting used t
+// CryptohomeClient::OnPkcs11GetTpmTokenInfo.
class CHROMEOS_EXPORT TPMTokenLoader : public LoginState::Observer {
public:
class Observer {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698