Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 386593002: Update TPMTokenLoader class comment. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
stevenjb, mattm
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update TPMTokenLoader class comment. BUG=210525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282822

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Total comments: 3

Patch Set 3 : Reworded. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chromeos/tpm_token_loader.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pneubeck (no reviews)
6 years, 5 months ago (2014-07-10 19:29:10 UTC) #1
mattm
lgtm with nits https://codereview.chromium.org/386593002/diff/1/chromeos/tpm_token_loader.h File chromeos/tpm_token_loader.h (right): https://codereview.chromium.org/386593002/diff/1/chromeos/tpm_token_loader.h#newcode26 chromeos/tpm_token_loader.h:26: // This class is responsible for ...
6 years, 5 months ago (2014-07-10 22:06:26 UTC) #2
pneubeck (no reviews)
6 years, 5 months ago (2014-07-11 15:33:03 UTC) #3
stevenjb
owner lgtm https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loader.h File chromeos/tpm_token_loader.h (right): https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loader.h#newcode26 chromeos/tpm_token_loader.h:26: // This class is responsible for loading ...
6 years, 5 months ago (2014-07-11 16:30:08 UTC) #4
pneubeck (no reviews)
https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loader.h File chromeos/tpm_token_loader.h (right): https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loader.h#newcode31 chromeos/tpm_token_loader.h:31: // Note: This currently loads the hard coded default ...
6 years, 5 months ago (2014-07-12 09:48:14 UTC) #5
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-12 09:48:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/386593002/60001
6 years, 5 months ago (2014-07-12 09:49:13 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 11:28:28 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 13:01:23 UTC) #9
Message was sent while issue was closed.
Change committed as 282822

Powered by Google App Engine
This is Rietveld 408576698