Update TPMTokenLoader class comment.

Update TPMTokenLoader class comment.

BUG=210525
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282822

[mattm, 2014-07-10 22:06:26]

lgtm with nits

https://codereview.chromium.org/386593002/diff/1/chromeos/tpm_token_loader.h
File chromeos/tpm_token_loader.h (right):

https://codereview.chromium.org/386593002/diff/1/chromeos/tpm_token_loader.h#...
chromeos/tpm_token_loader.h:26: // This class is responsible for loading the TPM
backed system token when the
nit: "TPM backed token and system slot"

https://codereview.chromium.org/386593002/diff/1/chromeos/tpm_token_loader.h#...
chromeos/tpm_token_loader.h:32: // CryptohomeClient.
nit: Maybe be more precise like "See CryptohomeClient::OnPkcs11GetTpmTokenInfo."
?

[stevenjb, 2014-07-11 16:30:08]

owner lgtm

https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loader.h
File chromeos/tpm_token_loader.h (right):

https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loade...
chromeos/tpm_token_loader.h:26: // This class is responsible for loading the TPM
backed token and system slot
nit: 'setting the system slot'? I'm not super familiar with TPM semantics, but
one doesn't usually "load" a "slot".

https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loade...
chromeos/tpm_token_loader.h:31: // Note: This currently loads the hard coded
default slot with id 0. See
Also here, "sets the hard coded default slot to id 0"?

[pneubeck (no reviews), 2014-07-12 09:48:14]

https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loader.h
File chromeos/tpm_token_loader.h (right):

https://codereview.chromium.org/386593002/diff/20001/chromeos/tpm_token_loade...
chromeos/tpm_token_loader.h:31: // Note: This currently loads the hard coded
default slot with id 0. See
On 2014/07/11 16:30:07, stevenjb wrote:
> Also here, "sets the hard coded default slot to id 0"?

Yeah, the crypto nomenclature takes getting used to. As the slot is the result
type of opening a NSS DB, I think 'setting' wouldn't be correct either.
I'll change it to initializing.

[pneubeck (no reviews), 2014-07-12 09:48:17]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-07-12 09:49:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/386593002/60001

[commit-bot: I haz the power, 2014-07-12 11:28:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-07-12 13:01:23]

Change committed as 282822