Gracefully handle icu errors when checking for enterprise domains.

Gracefully handle icu errors when checking for enterprise domains.

We shouldn't ever get ICU errors when checking for enterprise domains, but
apparently they do happen out in the field. Instead of crashing, we instead
gracefully handle errors by treating domains in that case as potential
enterprise domains (skipping the optimization).

BUG=365351
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282347

[Andrew T Wilson (Slow), 2014-07-10 08:58:06]

PTAL

[Joao da Silva, 2014-07-10 10:23:41]

Fix lgtm, see suggestion inline.

https://codereview.chromium.org/386573002/diff/1/components/policy/core/brows...
File components/policy/core/browser/browser_policy_connector.cc (right):

https://codereview.chromium.org/386573002/diff/1/components/policy/core/brows...
components/policy/core/browser/browser_policy_connector.cc:53: DLOG(ERROR) <<
"Possible invalid domain pattern: " << pattern
WDYT of gathering some UMA samples for this? We could sample the index of the
broken pattern & the status UErrorCode; and maybe the platform & locale too.

[Andrew T Wilson (Slow), 2014-07-10 11:05:26]

On 2014/07/10 10:23:41, Joao da Silva wrote:
> Fix lgtm, see suggestion inline.
> 
>
https://codereview.chromium.org/386573002/diff/1/components/policy/core/brows...
> File components/policy/core/browser/browser_policy_connector.cc (right):
> 
>
https://codereview.chromium.org/386573002/diff/1/components/policy/core/brows...
> components/policy/core/browser/browser_policy_connector.cc:53: DLOG(ERROR) <<
> "Possible invalid domain pattern: " << pattern
> WDYT of gathering some UMA samples for this? We could sample the index of the
> broken pattern & the status UErrorCode; and maybe the platform & locale too.

I'm adding a bunch of new UMA support to the policy code - I'll add something to
that CL.

[Andrew T Wilson (Slow), 2014-07-10 11:05:52]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2014-07-10 11:07:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/atwilson@chromium.org/386573002/1

[commit-bot: I haz the power, 2014-07-10 12:51:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-10 16:23:18]

Change committed as 282347