Add dexing for libraries and apks

Add dexing for libraries and apks

Apks need to get the paths to all the dependent library dex files to
merge into the final classes.dex file for the apk.

Depends on http://crrev.com/379333003

BUG=359249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286345

[cjhopman, 2014-07-12 00:04:29]

ajwong: *

Not sure if you wanted to review changes around here or not.

[awong, 2014-07-12 05:48:49]

FYI...I'm out for the next 2 weeks. Probably better to hit jamesr or brettw.
On 11 Jul 2014 17:04, <cjhopman@chromium.org> wrote:

> Reviewers: awong,
>
> Message:
> ajwong: *
>
> Not sure if you wanted to review changes around here or not.
>
> Description:
> Add dexing for libraries and apks
>
> Apks need to get the paths to all the dependent library dex files to
> merge into the final classes.dex file for the apk.
>
> Depends on http://crrev.com/379333003
>
> BUG=359249
>
> Please review this at https://codereview.chromium.org/386473002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@gn-apk-first
>
> Affected files (+102, -18 lines):
>   M build/android/gyp/dex.py
>   M build/android/gyp/write_build_config.py
>   M build/config/android/internal_rules.gni
>   M build/config/android/rules.gni
>   M ui/android/BUILD.gn
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cjhopman, 2014-07-18 00:58:26]

newt: *

[newt (away), 2014-07-18 21:19:19]

lgtm with two nits and a question

https://codereview.chromium.org/386473002/diff/80001/build/android/gyp/write_...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/386473002/diff/80001/build/android/gyp/write_...
build/android/gyp/write_build_config.py:158: dex_deps_files.reverse()
I'm guessing reversing these is important. Could you document why?

https://codereview.chromium.org/386473002/diff/80001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/386473002/diff/80001/build/config/android/int...
build/config/android/internal_rules.gni:126: rebase_output =
rebase_path(invoker.output, root_build_dir)
s/rebase/rebased

https://codereview.chromium.org/386473002/diff/80001/build/config/android/int...
build/config/android/internal_rules.gni:288: dex("${target_name}__dex") {
I didn't realize we generated a dex file for each library. What's the advantage
of that vs just dexing up all the library jars once we get to the APK step?

[cjhopman, 2014-07-28 21:58:52]

https://codereview.chromium.org/386473002/diff/80001/build/android/gyp/write_...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/386473002/diff/80001/build/android/gyp/write_...
build/android/gyp/write_build_config.py:158: dex_deps_files.reverse()
On 2014/07/18 21:19:18, newt wrote:
> I'm guessing reversing these is important. Could you document why?
I did this because it made them the same order as we have in gyp. It seems to
work fine without it, so i'll just remove it for now (and add it back with a
comment about why it's needed if it's needed).

https://codereview.chromium.org/386473002/diff/80001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/386473002/diff/80001/build/config/android/int...
build/config/android/internal_rules.gni:126: rebase_output =
rebase_path(invoker.output, root_build_dir)
On 2014/07/18 21:19:18, newt wrote:
> s/rebase/rebased

Done.

https://codereview.chromium.org/386473002/diff/80001/build/config/android/int...
build/config/android/internal_rules.gni:288: dex("${target_name}__dex") {
On 2014/07/18 21:19:18, newt wrote:
> I didn't realize we generated a dex file for each library. What's the
advantage
> of that vs just dexing up all the library jars once we get to the APK step?

Dexing is slow. Doing it this way makes it so that we only dex each library once
(instead of once per apk) and allows us to do the dexing of the library as soon
as possible (instead of waiting until the apk is ready to be built).

[cjhopman, 2014-07-28 21:59:08]

brettw for OWNERS

[brettw, 2014-07-28 22:22:45]

lgtm

https://codereview.chromium.org/386473002/diff/120001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/386473002/diff/120001/build/config/android/ru...
build/config/android/rules.gni:557: args =
["--inputs=@FileArg(${rebased_build_config}:apk_dex:dependency_dex_files)"]
Can you put the string on the next line and the ] on the following one? I think
this will prevent wrapping.

[cjhopman, 2014-07-29 21:02:15]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-07-29 21:04:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/386473002/140001

[commit-bot: I haz the power, 2014-07-29 23:53:12]

Change committed as 286345