chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc - Issue 386463002: Remove --disable-fullscreen-within-tab command-line flag.

Unified Diff: chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc

Issue 386463002: Remove --disable-fullscreen-within-tab command-line flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc

diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc b/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc

index 16f41b74d645517e3e12f33ad665e5feeb46e049..d37b165b55697a42b87d2be26f8991e6ac40ca37 100644

--- a/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc

+++ b/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc

@@ -485,10 +485,7 @@ TEST_F(FullscreenControllerStateUnitTest, ExitTabFullscreenViaReplacingTab) {

TEST_F(FullscreenControllerStateUnitTest, OneCapturedFullscreenedTab) {

content::WebContentsDelegate* const wc_delegate =

static_cast<content::WebContentsDelegate*>(browser());

- if (!wc_delegate->EmbedsFullscreenWidget()) {

- LOG(WARNING) << "Skipping test since fullscreen-within-tab is disabled.";

- return;

- }

+ ASSERT_TRUE(wc_delegate->EmbedsFullscreenWidget());

AddTab(browser(), GURL(url::kAboutBlankURL));

@@ -552,10 +549,7 @@ TEST_F(FullscreenControllerStateUnitTest, OneCapturedFullscreenedTab) {

TEST_F(FullscreenControllerStateUnitTest, TwoFullscreenedTabsOneCaptured) {

content::WebContentsDelegate* const wc_delegate =

static_cast<content::WebContentsDelegate*>(browser());

- if (!wc_delegate->EmbedsFullscreenWidget()) {

- LOG(WARNING) << "Skipping test since fullscreen-within-tab is disabled.";

- return;

- }

+ ASSERT_TRUE(wc_delegate->EmbedsFullscreenWidget());

AddTab(browser(), GURL(url::kAboutBlankURL));

@@ -613,10 +607,7 @@ TEST_F(FullscreenControllerStateUnitTest,

BackgroundCapturedTabExitsFullscreen) {

content::WebContentsDelegate* const wc_delegate =

static_cast<content::WebContentsDelegate*>(browser());

- if (!wc_delegate->EmbedsFullscreenWidget()) {

- LOG(WARNING) << "Skipping test since fullscreen-within-tab is disabled.";

- return;

- }

+ ASSERT_TRUE(wc_delegate->EmbedsFullscreenWidget());

AddTab(browser(), GURL(url::kAboutBlankURL));

@@ -672,10 +663,7 @@ TEST_F(FullscreenControllerStateUnitTest,

OneCapturedTabFullscreenedBeforeBrowserFullscreen) {

content::WebContentsDelegate* const wc_delegate =

static_cast<content::WebContentsDelegate*>(browser());

- if (!wc_delegate->EmbedsFullscreenWidget()) {

- LOG(WARNING) << "Skipping test since fullscreen-within-tab is disabled.";

- return;

- }

+ ASSERT_TRUE(wc_delegate->EmbedsFullscreenWidget());

AddTab(browser(), GURL(url::kAboutBlankURL));

content::WebContents* const tab =

@@ -726,10 +714,7 @@ TEST_F(FullscreenControllerStateUnitTest,

CapturedFullscreenedTabTransferredBetweenBrowserWindows) {

content::WebContentsDelegate* const wc_delegate =

static_cast<content::WebContentsDelegate*>(browser());

- if (!wc_delegate->EmbedsFullscreenWidget()) {

- LOG(WARNING) << "Skipping test since fullscreen-within-tab is disabled.";

- return;

- }

+ ASSERT_TRUE(wc_delegate->EmbedsFullscreenWidget());

AddTab(browser(), GURL(url::kAboutBlankURL));

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/fullscreen/fullscreen_controller.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »