Allow the test bots to easily run the password manager python tests.

components/test/data/password_manager/run_tests.py

+# -*- coding: utf-8 -*-
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""This file allows the bots to be easily configure and run the tests."""
+
+import argparse
+import os
+import tempfile
+
+from environment import Environment
+import tests
+
+if __name__ == "__main__":
+  parser = argparse.ArgumentParser(
+      description="Password Manager automated tests runner help.")
+  parser.add_argument(
+      "--chrome-path", action="store", dest="chrome_path",
+      help="Set the chrome path (required).", nargs=1, required=True)
+  parser.add_argument(
+      "--chromedriver-path", action="store", dest="chromedriver_path",
+      help="Set the chromedriver path (required).", nargs=1, required=True)
+  parser.add_argument(
+      "--profile-path", action="store", dest="profile_path",
+      help="Set the profile path (required). You just need to choose a "
+           "temporary empty folder. If the folder is not empty all its content "
+           "is going to be removed.",
+      nargs=1, required=True)
+  parser.add_argument(
+      "--passwords-path", action="store", dest="passwords_path",
+      help="Set the usernames/passwords path (required).", nargs=1,
+      required=True)
+  parser.add_argument("--save-path", action="store", nargs=1, dest="save_path",
+      help="Write the results in a file.", required=True)
+  args = parser.parse_args()
+
+  environment = Environment('', '', '', None, False)
+  tests.Tests(environment)
+
+  xml = open(args.save_path[0],"w")
+  results = tempfile.NamedTemporaryFile(dir=os.path.join(tempfile.gettempdir()),

[vabr (Chromium), 2014/07/14 12:36:09]

nit: Could you break the line so that all the arguments are on one line? I.e.:
var = function(
    arg, arg, arg)

[rchtara, 2014/07/16 07:55:11]

Done.

+      delete=False)

[vabr (Chromium), 2014/07/14 12:36:09]

Instead of creating the results here, and with delete=False, I suggest only
creating it just before using it (below), with delete=True.

I understand that one of the requirements for tests run on trybots is that they
clean up after themselves, so we should make sure that no files created are kept
on the disk.

If you need to keep the code this way, then please make sure to manually delete
|results| after the test is finished (and please check that that happens even if
some code between throws an uncaught exception).

[rchtara, 2014/07/16 07:55:11]

Done.

+  results_path = results.name
+  results.close()
+
+  full_path = os.path.realpath(__file__)
+  tests_dir = os.path.dirname(full_path)
+  tests_path = os.path.join(tests_dir, "tests.py")
+
+  xml.write("<xml>")
+  for websitetest in environment.websitetests:
+    # repeat the tests three times.

[vabr (Chromium), 2014/07/14 12:36:09]

Could you please also explain why the tests are repeated 3 times?

[vabr (Chromium), 2014/07/14 12:36:10]

nit: repeat->Repeat (A capital letter at the beginning.)

[rchtara, 2014/07/16 07:55:11]

Done.

+    for x in range(0, 3):
+      os.system("pkill -f chrome")
+      try:
+        os.remove(results_path)
+      except OSError:
+        pass
+
+      os.system("timeout 300 python %s %s --chrome-path %s --chromedriver-path "

[vabr (Chromium), 2014/07/14 12:36:09]

Please comment on the choice of 300 (including stating it means 300 seconds).

[vabr (Chromium), 2014/07/14 12:36:10]

@sergiyb: Is this the way tests on trybots should impose time restrictions on
their runtime? Or should specifying timeout be part of the recipe or other piece
of configuration?

[rchtara, 2014/07/16 07:55:11]

Done.

[Sergiy Byelozyorov, 2014/07/16 12:22:43]

That doesn't look like a good approach and I hope there is a better way. Please
ask on chrome-recipes@ as I have not actually written any recipes. I only know
about them theoretically.

[rchtara, 2014/07/16 16:31:58]

OK, I have just posted the question in chrome-recipes@.
Thanks a lot @sergiyb

+          "%s --passwords-path %s --profile-path %s --save-path %s" %
+          (tests_path, websitetest.name, args.chrome_path[0],
+           args.chromedriver_path[0], args.passwords_path[0],
+           args.profile_path[0], results_path))
+      if os.path.isfile(results_path):
+        results = open(results_path, "r")
+        for line in results:
+          xml.write(line)
+        results.close()
+      else:
+        xml.write("<result><test name='%s' type='prompt' successful='false'>"
+            "</test><test name='%s' type='normal' successful='false'></test>"
+            "</result>" % (websitetest.name, websitetest.name))
+
+  xml.write("</xml>")
+  xml.close()