WebAudio: Split AudioNode::finishDeref into two parts.

WebAudio: Split AudioNode::finishDeref into two parts.

Split finishDeref into
 - Disconnection processing part, and
 - Normal lifetime management part.

This CL adds AudioContext::addDeferredBreakConnection() to defer them
independently.

At this momenet deref() and breakConnection() have very similar code to acquire
lock. We're going to remove deref() by Oilpan.

BUG=392788
TEST=none; no behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178123

[tkent, 2014-07-14 09:36:51]

Please review this.

[Raymond Toy, 2014-07-14 16:43:01]

lgtm with nit

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioNode.cpp (right):

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioNode.cpp:529: // The actually work for deref
happens completely within the audio context's
Typo: "actually" -> "actual"

[sof, 2014-07-14 19:09:26]

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.cpp (left):

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.cpp:743: AudioNode* node =
m_deferredFinishDerefList[i];
style nit: if you want to use a consistent style in these two loops, shorten out
'node' ?

[tkent, 2014-07-15 01:19:24]

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.cpp (left):

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.cpp:743: AudioNode* node =
m_deferredFinishDerefList[i];
On 2014/07/14 19:09:26, sof wrote:
> style nit: if you want to use a consistent style in these two loops, shorten
out
> 'node' ?

Done.

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioNode.cpp (right):

https://codereview.chromium.org/386403002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioNode.cpp:529: // The actually work for deref
happens completely within the audio context's
On 2014/07/14 16:43:01, Raymond Toy wrote:
> Typo: "actually" -> "actual"

Done.  Also fixed it in deref().

[tkent, 2014-07-15 01:19:27]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-15 01:20:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/386403002/20001

[commit-bot: I haz the power, 2014-07-15 02:21:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/15449)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-07-15 02:59:53]

Change committed as 178123