Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 386373002: [SyncFS] Add per-URL promote of demoted changes in LocalFileChangeTracker (Closed)

Created:
6 years, 5 months ago by tzik
Modified:
6 years, 5 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Add per-URL promote of demoted changes in LocalFileChangeTracker BUG=344769 TEST=unit_tests --gtest_filter=LocalFileChangeTrackerTest.DemoteAndPromote Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282933

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop irrelevant DCHECK #

Patch Set 3 : fix #

Patch Set 4 : +test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -17 lines) Patch
M chrome/browser/sync_file_system/local/local_file_change_tracker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 1 2 9 chunks +34 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tzik
PTL
6 years, 5 months ago (2014-07-14 07:45:14 UTC) #1
peria
https://codereview.chromium.org/386373002/diff/1/chrome/browser/sync_file_system/local/local_file_change_tracker.cc File chrome/browser/sync_file_system/local/local_file_change_tracker.cc (right): https://codereview.chromium.org/386373002/diff/1/chrome/browser/sync_file_system/local/local_file_change_tracker.cc#newcode241 chrome/browser/sync_file_system/local/local_file_change_tracker.cc:241: DCHECK(!ContainsKey(demoted_changes_, url)); This DCHECK must fail. |url| is found ...
6 years, 5 months ago (2014-07-14 07:55:32 UTC) #2
tzik
https://codereview.chromium.org/386373002/diff/1/chrome/browser/sync_file_system/local/local_file_change_tracker.cc File chrome/browser/sync_file_system/local/local_file_change_tracker.cc (right): https://codereview.chromium.org/386373002/diff/1/chrome/browser/sync_file_system/local/local_file_change_tracker.cc#newcode241 chrome/browser/sync_file_system/local/local_file_change_tracker.cc:241: DCHECK(!ContainsKey(demoted_changes_, url)); On 2014/07/14 07:55:32, peria wrote: > This ...
6 years, 5 months ago (2014-07-14 08:03:49 UTC) #3
peria
LGTM. I recommend to add a unit test to go through the new method, though ...
6 years, 5 months ago (2014-07-14 08:06:56 UTC) #4
tzik
On 2014/07/14 08:06:56, peria wrote: > LGTM. > > I recommend to add a unit ...
6 years, 5 months ago (2014-07-14 08:38:49 UTC) #5
peria
LGTM again. Please add TEST line in the description.
6 years, 5 months ago (2014-07-14 08:43:25 UTC) #6
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 5 months ago (2014-07-14 09:05:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/386373002/50001
6 years, 5 months ago (2014-07-14 09:06:34 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 11:47:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 282933

Powered by Google App Engine
This is Rietveld 408576698