Issue 386333002: Files.app: Disable formatting menu for read only volumes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 386333002: Files.app: Disable formatting menu for read only volumes. (Closed)

Created:
6 years, 5 months ago by kinaba

Modified:
6 years, 5 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Disable formatting menu for read only volumes. The purpose of this change is to disable the menu for write-protected SD cards that anyhow fails to format. Strictly speaking this is excessive, because there may be a volume with read-only file system that still is formattable. We however assume that the practical need for the case is low (see discussion in the BUG.) BUG=334108 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282907