src/x64/assembler-x64.cc - Issue 38613003: Use PopReturnAddressTo and PushReturnAddressFrom in Generate_MarkCodeAsExecutedOnce builtin function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 38613003: Use PopReturnAddressTo and PushReturnAddressFrom in Generate_MarkCodeAsExecutedOnce builtin function (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 9fe7b8392e7a3a55b188b8d2769ae3363b6172de..1502d7934098272debb7f7f9e8c6701bbeeba68a 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -110,8 +110,8 @@ void RelocInfo::PatchCodeWithCall(Address target, int guard_bytes) {

#endif

// Patch the code.

- patcher.masm()->movq(r10, target, RelocInfo::NONE64);

- patcher.masm()->call(r10);

+ patcher.masm()->movq(kScratchRegister, target, RelocInfo::NONE64);

+ patcher.masm()->call(kScratchRegister);

// Check that the size of the code generated is as expected.

ASSERT_EQ(Assembler::kCallSequenceLength,

« no previous file with comments | « no previous file | src/x64/builtins-x64.cc » ('j') | no next file with comments »