Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 38613003: Use PopReturnAddressTo and PushReturnAddressFrom in Generate_MarkCodeAsExecutedOnce builtin function (Closed)

Created:
7 years, 2 months ago by haitao.feng
Modified:
7 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Use PopReturnAddressTo and PushReturnAddressFrom in Generate_MarkCodeAsExecutedOnce builtin function for X64 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/x64/assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL. Also replaced r10 with kScratchRegister in X64.
7 years, 2 months ago (2013-10-24 02:50:31 UTC) #1
danno
lgtm
7 years, 2 months ago (2013-10-24 07:04:21 UTC) #2
haitao.feng
7 years, 2 months ago (2013-10-24 07:39:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17357 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698