Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 386073002: Revert of [Android] Add heap_profiler_unittests to Android bots. (Closed)

Created:
6 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
bulach, navabi, navabi1
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@libheap_profiler
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add heap_profiler_unittests to Android bots. (https://codereview.chromium.org/351183003/) Reason for revert: It seems to be breaking some internal bots. :-/ Original issue's description: > [Android] Add heap_profiler_unittests to Android bots. > > Add proper coverage to heap_profiler. > > BUG=382489 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282626 TBR=aurimas@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Primiano Tucci (use gerrit)
Created Revert of [Android] Add heap_profiler_unittests to Android bots.
6 years, 5 months ago (2014-07-11 18:45:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/386073002/1
6 years, 5 months ago (2014-07-11 18:47:09 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 18:47:10 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-11 18:47:11 UTC) #4
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-07-11 18:48:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/386073002/1
6 years, 5 months ago (2014-07-11 18:50:02 UTC) #6
Primiano Tucci (use gerrit)
The CQ bit was unchecked by primiano@chromium.org
6 years, 5 months ago (2014-07-11 18:52:09 UTC) #7
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-07-11 18:52:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/386073002/1
6 years, 5 months ago (2014-07-11 18:54:19 UTC) #9
commit-bot: I haz the power
Change committed as 282656
6 years, 5 months ago (2014-07-11 18:55:47 UTC) #10
navabi1
6 years, 5 months ago (2014-07-11 19:13:15 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698