tools/telemetry/telemetry/core/platform/android_platform_backend.py - Issue 386053002: [Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 386053002: [Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pre-review cleanup Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/device/device_utils.py ('K') | « tools/android/adb_profile_chrome/perf_controller.py ('k') | tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

index 01b293077df2496c3255049eaa6cc843c03ef5de..e49542b5dd82665635a2ba44920dfc359974cf75 100644

--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

@@ -200,7 +200,7 @@ class AndroidPlatformBackend(

def IsApplicationRunning(self, application):

if application in _HOST_APPLICATIONS:

return platform.GetHostPlatform().IsApplicationRunning(application)

- return len(self._device.old_interface.ExtractPid(application)) > 0

+ return len(self._device.GetPid(application)) > 0

def CanLaunchApplication(self, application):

if application in _HOST_APPLICATIONS: