tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py - Issue 386053002: [Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

Issue 386053002: [Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

index 139cd3783b08aab1e6074ac0868cc51e10dd1b82..23396eb1cdffa8b66baf76e421e2ea1ec623208d 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

@@ -100,10 +100,7 @@ class _SingleProcessPerfProfiler(object):

'"--extra-browser-args=--single-process"')

if self._is_android:

device = self._browser_backend.adb.device()

- perf_pids = device.old_interface.ExtractPid('perf')

- device.RunShellCommand('kill -SIGINT ' + ' '.join(perf_pids))

- util.WaitFor(lambda: not device.old_interface.ExtractPid('perf'),

- timeout=2)

+ device.KillAll('perf', signum=signal.SIGINT, blocking=True)

self._proc.send_signal(signal.SIGINT)

exit_code = self._proc.wait()

try:

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | no next file » | no next file with comments »