tools/android/adb_profile_chrome/perf_controller.py - Issue 386053002: [Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/perf_controller.py

Issue 386053002: [Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/adb_profile_chrome/perf_controller.py

diff --git a/tools/android/adb_profile_chrome/perf_controller.py b/tools/android/adb_profile_chrome/perf_controller.py

index c7d573e407596c3fd6e8df2a50433b828ec4f42d..372cf27e63a0ec6ea994604e8162883e2d418bd9 100644

--- a/tools/android/adb_profile_chrome/perf_controller.py

+++ b/tools/android/adb_profile_chrome/perf_controller.py

@@ -64,8 +64,7 @@ class _PerfProfiler(object):

stderr=subprocess.STDOUT)

def SignalAndWait(self):

- perf_pids = self._device.old_interface.ExtractPid('perf')

- self._device.RunShellCommand('kill -SIGINT ' + ' '.join(perf_pids))

+ self._device.KillAll('perf', signum=signal.SIGINT)

self._perf_process.wait()

self._perf_control.SetDefaultPerfMode()

« no previous file with comments | « build/android/screenshot.py ('k') | tools/telemetry/telemetry/core/platform/android_platform_backend.py » ('j') | no next file with comments »