Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 386043006: Whitelist beta and dev channel ids for spark. (Closed)

Created:
6 years, 5 months ago by Gaurav
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Whitelist beta and dev channel ids for spark. BUG=392678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Gaurav
6 years, 5 months ago (2014-07-12 00:00:03 UTC) #1
dvh
On 2014/07/12 00:00:03, Gaurav wrote: lgtm.
6 years, 5 months ago (2014-07-12 04:47:41 UTC) #2
Gaurav
The CQ bit was checked by grv@chromium.org
6 years, 5 months ago (2014-07-14 20:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/386043006/1
6 years, 5 months ago (2014-07-14 20:01:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 22:23:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 22:27:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79866)
6 years, 5 months ago (2014-07-14 22:27:21 UTC) #7
Gaurav
The CQ bit was checked by grv@chromium.org
6 years, 5 months ago (2014-07-15 20:21:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/386043006/1
6 years, 5 months ago (2014-07-15 20:23:40 UTC) #9
Gaurav
@asargent need a lgtm from the owner. Thanks.
6 years, 5 months ago (2014-07-15 20:26:13 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 21:53:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 22:04:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80090)
6 years, 5 months ago (2014-07-15 22:04:07 UTC) #13
Gaurav
@asargent
6 years, 5 months ago (2014-07-16 20:27:00 UTC) #14
asargent_no_longer_on_chrome
lgtm
6 years, 5 months ago (2014-07-16 21:59:24 UTC) #15
Gaurav
The CQ bit was checked by grv@chromium.org
6 years, 5 months ago (2014-07-17 19:25:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/386043006/1
6 years, 5 months ago (2014-07-17 19:29:30 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:52:22 UTC) #18
Message was sent while issue was closed. 
Change committed as 283841

Powered by Google App Engine
This is Rietveld 408576698