Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 386043004: Audio Player: Add support for Media Keys (Closed)

Created:
6 years, 5 months ago by etrunko
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, nathan ciobanu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Audio Player: Add support for Media Keys BUG=393346 R=yoshiki@chromium.org TEST=Manually tested with external USB keyboard Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283431

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ui/file_manager/file_manager/audio_player/elements/audio_player.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
etrunko
6 years, 5 months ago (2014-07-11 22:01:11 UTC) #1
yoshiki
lgtm with a nit. Thanks! https://codereview.chromium.org/386043004/diff/1/ui/file_manager/file_manager/audio_player/elements/audio_player.js File ui/file_manager/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/386043004/diff/1/ui/file_manager/file_manager/audio_player/elements/audio_player.js#newcode353 ui/file_manager/file_manager/audio_player/elements/audio_player.js:353: //TODO: Define "Stop" behavior. ...
6 years, 5 months ago (2014-07-14 23:49:12 UTC) #2
etrunko
The CQ bit was checked by eduardo.lima@intel.com
6 years, 5 months ago (2014-07-15 13:30:31 UTC) #3
etrunko
https://codereview.chromium.org/386043004/diff/1/ui/file_manager/file_manager/audio_player/elements/audio_player.js File ui/file_manager/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/386043004/diff/1/ui/file_manager/file_manager/audio_player/elements/audio_player.js#newcode353 ui/file_manager/file_manager/audio_player/elements/audio_player.js:353: //TODO: Define "Stop" behavior. On 2014/07/14 23:49:12, yoshiki wrote: ...
6 years, 5 months ago (2014-07-15 13:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eduardo.lima@intel.com/386043004/20001
6 years, 5 months ago (2014-07-15 13:32:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 23:18:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 00:28:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170862)
6 years, 5 months ago (2014-07-16 00:28:25 UTC) #8
etrunko
The CQ bit was checked by eduardo.lima@intel.com
6 years, 5 months ago (2014-07-16 12:25:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eduardo.lima@intel.com/386043004/20001
6 years, 5 months ago (2014-07-16 12:26:44 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:04:05 UTC) #11
Message was sent while issue was closed. 
Change committed as 283431

Powered by Google App Engine
This is Rietveld 408576698