Added wrapper test class for touch_exploration_controller.

Added wrapper test class for touch_exploration_controller.
Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller.

BUG=377040
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283741

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284483

[dmazzoni, 2014-07-16 15:01:02]

lgtm

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
ui/chromeos/touch_exploration_controller_unittest.cc:103: const {
nit: this fits on the previous line

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
ui/chromeos/touch_exploration_controller_unittest.cc:109: const {
nit: same

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
ui/chromeos/touch_exploration_controller_unittest.cc:117: bool suppress) {
same

[evy, 2014-07-16 17:22:08]

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
ui/chromeos/touch_exploration_controller_unittest.cc:103: const {
On 2014/07/16 15:01:02, dmazzoni wrote:
> nit: this fits on the previous line

Done.

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
ui/chromeos/touch_exploration_controller_unittest.cc:109: const {
On 2014/07/16 15:01:02, dmazzoni wrote:
> nit: same

Done.

https://codereview.chromium.org/386043002/diff/1/ui/chromeos/touch_exploratio...
ui/chromeos/touch_exploration_controller_unittest.cc:117: bool suppress) {
On 2014/07/16 15:01:02, dmazzoni wrote:
> same

Done.

[evy, 2014-07-16 18:25:39]

The CQ bit was checked by evy@chromium.org

[commit-bot: I haz the power, 2014-07-16 18:31:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/evy@chromium.org/386043002/20001

[commit-bot: I haz the power, 2014-07-17 10:56:29]

Change committed as 283741

[gab, 2014-07-17 17:45:16]

A revert of this CL has been created in
https://codereview.chromium.org/404473006/ by gab@chromium.org.

The reason for reverting is: Causes LSAN errors on CrOS:
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

e.g.
Indirect leak of 2904 byte(s) in 1 object(s) allocated from:
    #0 0x44edfb in operator new(unsigned long)
/usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x9fbc47 in CreateStrategy
ui/events/gesture_detection/velocity_tracker.cc:201
    #2 0x9fbc47 in
ui::VelocityTracker::VelocityTracker(ui::VelocityTracker::Strategy)
ui/events/gesture_detection/velocity_tracker.cc:234
    #3 0x9fa322 in ui::VelocityTrackerState::VelocityTrackerState()
ui/events/gesture_detection/velocity_tracker_state.cc:18
    #4 0x9f5d64 in
ui::GestureDetector::GestureDetector(ui::GestureDetector::Config const&,
ui::GestureDetector::GestureListener*, ui::GestureDetector::DoubleTapListener*)
ui/events/gesture_detection/gesture_detector.cc:191
    #5 0x1431ddf in GestureListenerImpl
ui/events/gesture_detection/gesture_provider.cc:296
    #6 0x1431ddf in
ui::GestureProvider::InitGestureDetectors(ui::GestureProvider::Config const&)
ui/events/gesture_detection/gesture_provider.cc:629
    #7 0x142ebdd in
ui::FilteredGestureProvider::FilteredGestureProvider(ui::GestureProvider::Config
const&, ui::GestureProviderClient*)
ui/events/gesture_detection/filtered_gesture_provider.cc:19
    #8 0x1410cd3 in
ui::GestureProviderAura::GestureProviderAura(ui::GestureProviderAuraClient*)
ui/events/gestures/gesture_provider_aura.cc:19
    #9 0x9e9bcd in
ui::TouchExplorationController::TouchExplorationController(aura::Window*)
ui/chromeos/touch_exploration_controller.cc:33
    #10 0x663c47 in ui::TouchExplorationTest::SwitchTouchExplorationMode(bool)
ui/chromeos/touch_exploration_controller_unittest.cc:214
    #11 0x674532 in ui::TouchExplorationTest_DoubleTap_Test::TestBody()
ui/chromeos/touch_exploration_controller_unittest.cc:563
    #12 0x7babc8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
void> testing/gtest/src/gtest.cc:2045
    #13 0x7babc8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #14 0x7bcd08 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #15 0x7bda46 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #16 0x7d072a in testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4065
    #17 0x7cfd70 in
HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2045
    #18 0x7cfd70 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #19 0x7770b4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #20 0x7770b4 in base::TestSuite::Run() base/test/test_suite.cc:227
    #21 0x76e0c1 in Run base/callback.h:401
    #22 0x76e0c1 in base::(anonymous
namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int,
bool, base::Callback\u003Cvoid ()> const&)
base/test/launcher/unit_test_launcher.cc:498
    #23 0x76da5c in base::LaunchUnitTests(int, char**, base::Callback\u003Cint
()> const&) base/test/launcher/unit_test_launcher.cc:553
    #24 0x59cfaa in main ui/base/test/run_all_unittests.cc:105
    #25 0x7fd0195b276c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226.

[gab, 2014-07-17 17:46:10]

https://codereview.chromium.org/386043002/diff/20001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/386043002/diff/20001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:215: new
ui::TouchExplorationController(root_window())));
The ui::TouchExplorationController passed into the
TouchExplorationControllerTestApi is not owned by that class and thus leaks.

[evy, 2014-07-17 21:06:46]

https://codereview.chromium.org/386043002/diff/20001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/386043002/diff/20001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:215: new
ui::TouchExplorationController(root_window())));
On 2014/07/17 17:46:09, gab wrote:
> The ui::TouchExplorationController passed into the
> TouchExplorationControllerTestApi is not owned by that class and thus leaks.

Thank you for pointing to the problematic line of code!

@Dominic, Alice: 
I changed the code so the TestApi class stores the TouchExplorationController in
a scoped pointer, which I think fixes the problem.
Can you let me know if that's indeed the fix I needed, and also how to test for
indirect leaks? Alice sent me a thing before about the address sanitizer, but it
doesn't catch anything in this code.
Thanks :)

[gab, 2014-07-17 21:17:43]

https://codereview.chromium.org/386043002/diff/20001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/386043002/diff/20001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:215: new
ui::TouchExplorationController(root_window())));
On 2014/07/17 21:06:46, evy wrote:
> On 2014/07/17 17:46:09, gab wrote:
> > The ui::TouchExplorationController passed into the
> > TouchExplorationControllerTestApi is not owned by that class and thus leaks.
> 
> Thank you for pointing to the problematic line of code!

NP :)

> 
> @Dominic, Alice: 
> I changed the code so the TestApi class stores the TouchExplorationController
in
> a scoped pointer, which I think fixes the problem.
> Can you let me know if that's indeed the fix I needed, and also how to test
for
> indirect leaks? Alice sent me a thing before about the address sanitizer, but
it
> doesn't catch anything in this code.
> Thanks :)

First you'll want to trigger the ASAN try bots on this CL (via the "Try more
bots" button).

[gab, 2014-07-17 21:18:18]

PS: You probably want to re-open this CL too (or try bots won't run on closed
CLs) -- via the options in "Edit issue".

Cheers,
Gab

[evy, 2014-07-21 18:16:23]

The CQ bit was checked by evy@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:18:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/evy@chromium.org/386043002/40001

[commit-bot: I haz the power, 2014-07-21 19:46:00]

Change committed as 284483