Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 386033002: Prune shared extendion module after extension updating. (Closed)

Created:
6 years, 5 months ago by Peng
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, elijahtaylor1
Project:
chromium
Visibility:
Public.

Description

Prune shared extension module after extension updating. When an extension is updated, the imported module of the extension could be changed in the new version. If the imported modules are removed in the new version, we need check and remove the shared modules if necessary. BUG=393232 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283574

Patch Set 1 #

Patch Set 2 : Fix review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -73 lines) Patch
M chrome/browser/apps/drive/drive_app_provider.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/apps/drive/drive_app_provider.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_install_manager.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_install_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/shared_module_service.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/shared_module_service.cc View 1 2 chunks +46 lines, -22 lines 0 comments Download
M chrome/browser/extensions/shared_module_service_unittest.cc View 6 chunks +117 lines, -29 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_service.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_registry.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_registry.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/browser/extension_registry_observer.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Peng
PTAL. Thanks.
6 years, 5 months ago (2014-07-11 16:30:48 UTC) #1
asargent_no_longer_on_chrome
It seems like it would be a lot simpler if, any time an extension is ...
6 years, 5 months ago (2014-07-11 20:58:28 UTC) #2
Peng
PTAL. Thanks.
6 years, 5 months ago (2014-07-14 20:53:49 UTC) #3
Peng
+rlp@chromium.org for chrome/browser/search/* +tzik@chromium.org for chrome/browser/sync_file_system/* +pavely@chromium.org for chrome/browser/sync/*
6 years, 5 months ago (2014-07-14 21:07:27 UTC) #4
tzik
sync_file_system/ changes lgtm
6 years, 5 months ago (2014-07-15 01:28:56 UTC) #5
pavely
chrome/browser/sync/* lgtm
6 years, 5 months ago (2014-07-15 16:59:37 UTC) #6
rpetterson
On 2014/07/15 16:59:37, pavely wrote: > chrome/browser/sync/* lgtm chrome/browser/search/hotword* lgtm
6 years, 5 months ago (2014-07-15 19:53:22 UTC) #7
asargent_no_longer_on_chrome
lgtm
6 years, 5 months ago (2014-07-16 18:59:27 UTC) #8
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 5 months ago (2014-07-16 19:03:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/386033002/60001
6 years, 5 months ago (2014-07-16 19:06:47 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:27:54 UTC) #11
Message was sent while issue was closed.
Change committed as 283574

Powered by Google App Engine
This is Rietveld 408576698