Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/sync/engine/update_applicator.cc

Issue 386030: Relieve SyncerSession,SyncCycleState, SyncProcessState, SyncerSession, Syncer... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/update_applicator.h ('k') | chrome/browser/sync/engine/verify_updates_command.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/update_applicator.cc
===================================================================
--- chrome/browser/sync/engine/update_applicator.cc (revision 32731)
+++ chrome/browser/sync/engine/update_applicator.cc (working copy)
@@ -8,6 +8,7 @@
#include "base/logging.h"
#include "chrome/browser/sync/engine/syncer_util.h"
+#include "chrome/browser/sync/sessions/session_state.h"
#include "chrome/browser/sync/syncable/syncable.h"
#include "chrome/browser/sync/syncable/syncable_id.h"
@@ -73,18 +74,20 @@
return conflicting_ids_.empty() && begin_ == end_;
}
-void UpdateApplicator::SaveProgressIntoSessionState(SyncerSession* session) {
+void UpdateApplicator::SaveProgressIntoSessionState(
+ sessions::ConflictProgress* conflict_progress,
+ sessions::UpdateProgress* update_progress) {
DCHECK(begin_ == end_ || ((pointer_ == end_) && !progress_))
<< "SaveProgress called before updates exhausted.";
vector<syncable::Id>::const_iterator i;
for (i = conflicting_ids_.begin(); i != conflicting_ids_.end(); ++i) {
- session->AddCommitConflict(*i);
- session->AddAppliedUpdate(CONFLICT, *i);
+ conflict_progress->AddConflictingItemById(*i);
+ update_progress->AddAppliedUpdate(CONFLICT, *i);
}
for (i = successful_ids_.begin(); i != successful_ids_.end(); ++i) {
- session->EraseCommitConflict(*i);
- session->AddAppliedUpdate(SUCCESS, *i);
+ conflict_progress->EraseConflictingItemById(*i);
+ update_progress->AddAppliedUpdate(SUCCESS, *i);
}
}
« no previous file with comments | « chrome/browser/sync/engine/update_applicator.h ('k') | chrome/browser/sync/engine/verify_updates_command.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698