Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2844)

Unified Diff: chrome/browser/cocoa/tab_view.mm

Issue 386021: Add support for observing tracking areas so that when tabs are moved undernea... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/tab_strip_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/tab_view.mm
===================================================================
--- chrome/browser/cocoa/tab_view.mm (revision 31786)
+++ chrome/browser/cocoa/tab_view.mm (working copy)
@@ -116,6 +116,28 @@
}
}
+// The tracking areas have been moved. Make sure that the close button is
+// highlighting correctly with respect to the cursor position with the new
+// tracking area locations.
+- (void)updateTrackingAreas {
+ [super updateTrackingAreas];
+
+ // Update the close buttons if the tab has moved.
+ NSPoint mouseLoc = [[self window] mouseLocationOutsideOfEventStream];
+ mouseLoc = [self convertPointFromBase:mouseLoc];
+ NSString* name = nil;
+ if (NSPointInRect(mouseLoc, [closeButton_ frame])) {
+ name = @"close_bar_h.pdf";
+ } else {
+ name = @"close_bar.pdf";
+ }
+ NSImage* newImage = nsimage_cache::ImageNamed(name);
+ NSImage* buttonImage = [closeButton_ image];
+ if (![buttonImage isEqual:newImage]) {
+ [closeButton_ setImage:newImage];
+ }
+}
+
// Determines which view a click in our frame actually hit. It's either this
// view or our child close button.
- (NSView*)hitTest:(NSPoint)aPoint {
« no previous file with comments | « chrome/browser/cocoa/tab_strip_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698