Fix memory leak in ExtensionTest.LoadPageActionHelper unit test. The leak...

Fix memory leak in ExtensionTest.LoadPageActionHelper unit test. The leak
was in the test only, not in the app code.

BUG=26216
TEST=covered by Linux valgrind (1) buildbot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31606

[Pam (message me for reviews), 2009-11-10 20:23:38]

Dunno why it took so long for this leak to show up.

[Pam (message me for reviews), 2009-11-10 20:23:56]

Reviewers: Finnur,

Message:
Dunno why it took so long for this leak to show up.

Description:
Fix memory leak in ExtensionTest.LoadPageActionHelper unit test. The leak
was in the test only, not in the app code.

BUG=26216
TEST=covered by Linux valgrind (1) buildbot

Please review this at http://codereview.chromium.org/386002

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/common/extensions/extension_unittest.cc
   M     tools/valgrind/memcheck/suppressions.txt


Index: tools/valgrind/memcheck/suppressions.txt
===================================================================
--- tools/valgrind/memcheck/suppressions.txt	(revision 31588)
+++ tools/valgrind/memcheck/suppressions.txt	(working copy)
@@ -1059,14 +1059,6 @@
     fun:_ZN7WebCore9CSSParser10parseSheetEPNS_13CSSStyleSheetERKNS_6StringE
  }
  {
-   bug_26216
-   Memcheck:Leak
-   fun:_Znw*
-   ...
-   fun:_ZN9Extension25LoadExtensionActionHelperEPK15DictionaryValuePSs
-   fun:_ZN39ExtensionTest_LoadPageActionHelper_Test8TestBodyEv
-}
-{
     bug_26966
     Memcheck:Leak
     fun:malloc
Index: chrome/common/extensions/extension_unittest.cc
===================================================================
--- chrome/common/extensions/extension_unittest.cc	(revision 31588)
+++ chrome/common/extensions/extension_unittest.cc	(working copy)
@@ -302,8 +302,8 @@
    DictionaryValue input;

    // First try with an empty dictionary.
-  ASSERT_TRUE(extension.LoadExtensionActionHelper(
-      &input, &error_msg) != NULL);
+  action.reset(extension.LoadExtensionActionHelper(&input, &error_msg));
+  ASSERT_TRUE(action != NULL);
    ASSERT_STREQ("", error_msg.c_str());
    error_msg = "";

[Finnur, 2009-11-10 21:09:23]

LGTM

[Finnur, 2009-11-10 21:09:41]

LGTM

http://codereview.chromium.org/386002