Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385993004: Clean up Chrome OS WARNING spam (Closed)

Created:
6 years, 5 months ago by stevenjb
Modified:
6 years, 5 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, darin-cc_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, jln+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Clean up Chrome OS WARNING spam BUG=393266 For log only change to profile_io_data.cc (reviewed by mattm) TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283648

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, profile_io_data feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -58 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 11 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/system_clock_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/name_value_pairs_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/tpm_token_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/sandbox_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M dbus/property.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
stevenjb
If any of this logging is essential for feedback reports, etc, please add an entry ...
6 years, 5 months ago (2014-07-11 18:35:30 UTC) #1
mattm
https://codereview.chromium.org/385993004/diff/1/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://codereview.chromium.org/385993004/diff/1/chrome/browser/profiles/profile_io_data.cc#newcode366 chrome/browser/profiles/profile_io_data.cc:366: LOG(ERROR) << "No username_hash for: " << user->email(); Maybe ...
6 years, 5 months ago (2014-07-11 20:39:54 UTC) #2
stevenjb
https://codereview.chromium.org/385993004/diff/1/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (right): https://codereview.chromium.org/385993004/diff/1/chrome/browser/profiles/profile_io_data.cc#newcode366 chrome/browser/profiles/profile_io_data.cc:366: LOG(ERROR) << "No username_hash for: " << user->email(); On ...
6 years, 5 months ago (2014-07-14 17:13:14 UTC) #3
mattm
profile_io_data.cc lgtm
6 years, 5 months ago (2014-07-14 23:18:11 UTC) #4
michaelpg
system_clock_client.cc lgtm
6 years, 5 months ago (2014-07-15 00:08:14 UTC) #5
jln (very slow on Chromium)
content/common/sandbox_linux/sandbox_linux.cc looks fine to me, but I'll let jorgelo@ chime in, as he's been relying ...
6 years, 5 months ago (2014-07-15 16:51:58 UTC) #6
Jorge Lucangeli Obes
lgtm. it's not a huge deal now that we have sandbox info in about:gpu.
6 years, 5 months ago (2014-07-15 16:59:33 UTC) #7
stevenjb
+correct nkostylev@, ptal
6 years, 5 months ago (2014-07-15 19:09:16 UTC) #8
stevenjb
+ygorshenin@ for c/b/ui/webui/chromeos/login OWNER
6 years, 5 months ago (2014-07-16 18:27:47 UTC) #9
Nikita (slow)
lgtm
6 years, 5 months ago (2014-07-16 18:35:38 UTC) #10
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 5 months ago (2014-07-16 21:21:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/385993004/20001
6 years, 5 months ago (2014-07-16 21:30:06 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 05:04:08 UTC) #13
Message was sent while issue was closed. 
Change committed as 283648

Powered by Google App Engine
This is Rietveld 408576698