Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py

Issue 385983009: Update files in telemetry/results/ to use results.AddValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py
index d05423c161e9fd2161889fee2f6670c924565b78..a378fe1f5e0dc228e55832ea04b05299b130b857 100644
--- a/tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/results/html_page_measurement_results_unittest.py
@@ -7,6 +7,7 @@ import unittest
from telemetry.page import page_set
from telemetry.results import html_page_measurement_results
+from telemetry.value import scalar
def _MakePageSet():
@@ -41,12 +42,14 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):
results = DeterministicHtmlPageMeasurementResults(
output_file, 'test_name', False, False, 'browser_type')
results.WillMeasurePage(test_page_set.pages[0])
- results.Add('a', 'seconds', 3)
+ results.AddValue(scalar.ScalarValue(
+ test_page_set.pages[0], 'a', 'seconds', 3))
results.DidMeasurePage()
results.AddSuccess(test_page_set.pages[0])
results.WillMeasurePage(test_page_set.pages[1])
- results.Add('a', 'seconds', 7)
+ results.AddValue(scalar.ScalarValue(
+ test_page_set.pages[1], 'a', 'seconds', 7))
results.DidMeasurePage()
results.AddSuccess(test_page_set.pages[1])
@@ -96,12 +99,14 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):
results = DeterministicHtmlPageMeasurementResults(
output_file, 'test_name', False, False, 'browser_type')
results.WillMeasurePage(test_page_set.pages[0])
- results.Add('a', 'seconds', 4)
+ results.AddValue(scalar.ScalarValue(
+ test_page_set.pages[0], 'a', 'seconds', 4))
results.DidMeasurePage()
results.AddSuccess(test_page_set.pages[0])
results.WillMeasurePage(test_page_set.pages[1])
- results.Add('a', 'seconds', 8)
+ results.AddValue(scalar.ScalarValue(
+ test_page_set.pages[1], 'a', 'seconds', 8))
results.DidMeasurePage()
results.AddSuccess(test_page_set.pages[1])
@@ -189,12 +194,14 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):
results = DeterministicHtmlPageMeasurementResults(
output_file, 'test_name', True, False, 'browser_type')
results.WillMeasurePage(test_page_set.pages[0])
- results.Add('a', 'seconds', 5)
+ results.AddValue(scalar.ScalarValue(
+ test_page_set.pages[0], 'a', 'seconds', 5))
results.DidMeasurePage()
results.AddSuccess(test_page_set.pages[0])
results.WillMeasurePage(test_page_set.pages[1])
- results.Add('a', 'seconds', 9)
+ results.AddValue(scalar.ScalarValue(
+ test_page_set.pages[1], 'a', 'seconds', 9))
results.DidMeasurePage()
results.AddSuccess(test_page_set.pages[1])

Powered by Google App Engine
This is Rietveld 408576698