Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

Issue 385983009: Update files in telemetry/results/ to use results.AddValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
index 2ebc417d137b0b1128b4f7c2b1627f8e2cb17f15..071c40fb6d3666b164fc2a9e95836c4a7e3f8e84 100644
--- a/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
@@ -7,6 +7,7 @@ import unittest
from telemetry.page import page_set
from telemetry.results import block_page_measurement_results
+from telemetry.value import scalar
BlockPageMeasurementResults = \
@@ -43,11 +44,13 @@ class BlockPageMeasurementResultsTest(unittest.TestCase):
def test_with_output_after_every_page(self):
results = NonPrintingBlockPageMeasurementResults(self._output)
results.WillMeasurePage(self._page_set[0])
- results.Add('foo', 'seconds', 3)
+ results.AddValue(
+ scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
results.DidMeasurePage()
results.WillMeasurePage(self._page_set[1])
- results.Add('bar', 'seconds', 4)
+ results.AddValue(
+ scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 4))
results.DidMeasurePage()
expected = [
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698