mojo/monacl/README - Issue 385983008: Mojo + NaCl prototype.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/monacl/README

Issue 385983008: Mojo + NaCl prototype. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ClipDep Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 This is a prototype for plumbing Mojo into the NaCl sandbox. It is

	2 currently insecure (see below), does not provide a stable ABI (IRT

	3 support must be added), and does not support Mojo functions that

	4 return pointers (for example, MojoMapBuffer).

	5
	Mark Seaborn 2014/09/10 23:19:20 On naming: "monacl" is cutesy, but it's not necess On naming: "monacl" is cutesy, but it's not necessarily obvious that "monacl" is just "mojo + nacl". Wouldn't "mojo/nacl" be more obvious, and more consistent with other directories like "components/nacl"? Nick Bray (chromium) 2014/09/11 00:56:39 Bulk moved. Some instances of "monacl" not change Show quoted text On 2014/09/10 23:19:20, Mark Seaborn wrote: > On naming: "monacl" is cutesy, but it's not necessarily obvious that "monacl" is > just "mojo + nacl". > > Wouldn't "mojo/nacl" be more obvious, and more consistent with other directories > like "components/nacl"? Bulk moved. Some instances of "monacl" not changed due to lack of better name.
	6 generator/interface.py contains a programmatic description of the

	7 stable Mojo interface. This will need to be updated as the interface

	8 changes. Run generator/generate_monacl_bindings.py to generate the

	9 bindings that plumb this interface into the NaCl sandbox.

	10

	11 To test: Build "monacl_shell" and "monacl_test". Run monacl_shell

	12 with the IRT as the first argument and the monacl_test as the second

	13 argument. For example, to run a Debug 32-bit Intel build:

	14

	15 cd out/Debug

	16 ./monacl_shell irt_core_newlib_x32.nexe monacl_test_newlib_x32.nexe

	17

	18 Security TODO list:

	19 Separate trusted and untrusted Mojo handles.

	20 Validate and copy option structures.

	21 Protect untrusted buffers passed into Mojo:

	22 NaClVmIoWillStart/HasEnded.

	23 Data races.
	Mark Seaborn 2014/09/10 23:19:20 What do you mean by "data races"? Does this mean What do you mean by "data races"? Does this mean cases where trusted code accesses untrusted address space without proper atomic/volatile qualifiers? Nick Bray (chromium) 2014/09/11 00:56:39 Done. Show quoted text On 2014/09/10 23:19:20, Mark Seaborn wrote: > What do you mean by "data races"? Does this mean cases where trusted code > accesses untrusted address space without proper atomic/volatile qualifiers? Done.
OLD	NEW

« no previous file with comments | « mojo/monacl/DEPS ('k') | mojo/monacl/generator/NOT_FOR_COMMIT/libmojo.cc » ('j') | mojo/monacl/generator/generate_monacl_bindings.py » ('J')