mojo/monacl/README - Issue 385983008: Mojo + NaCl prototype.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/monacl/README

Issue 385983008: Mojo + NaCl prototype. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: GYP edit Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 This is a prototype for plumbing Mojo into the NaCl sandbox. It is

	2 currently insecure, does not provide a stable ABI, and does not
	Mark Seaborn 2014/09/09 19:13:11 Can you say what you mean by insecure, so people k Can you say what you mean by insecure, so people know what to review/fix in future? Known issues: * No use of NaClVmIoWillStart()/NaClVmIoHasEnded() when untrusted buffers are passed to Mojo code (e.g. for MojoWriteMessage()). * No separation between trusted & untrusted Mojo handles. Nick Bray (chromium) 2014/09/09 23:12:32 Done. Show quoted text On 2014/09/09 19:13:11, Mark Seaborn wrote: > Can you say what you mean by insecure, so people know what to review/fix in > future? > > Known issues: > > * No use of NaClVmIoWillStart()/NaClVmIoHasEnded() when untrusted buffers are > passed to Mojo code (e.g. for MojoWriteMessage()). > > * No separation between trusted & untrusted Mojo handles. Done.
	3 support Mojo functions that return pointers.
	Mark Seaborn 2014/09/09 19:13:11 ...for example, MojoMapBuffer()? (If I understand ...for example, MojoMapBuffer()? (If I understand this correctly.) Nick Bray (chromium) 2014/09/09 23:12:32 Done. Show quoted text On 2014/09/09 19:13:11, Mark Seaborn wrote: > ...for example, MojoMapBuffer()? (If I understand this correctly.) Done.
	4

	5 gen/interface.py contains a programmatic description of the stable
	Mark Seaborn 2014/09/09 19:13:11 It's now generator/interface.py. It's now generator/interface.py. Nick Bray (chromium) 2014/09/09 23:12:32 Done. Show quoted text On 2014/09/09 19:13:11, Mark Seaborn wrote: > It's now generator/interface.py. Done.
	6 Mojo interface. This will need to be updated as the interface

	7 changes. Run gen/generate_monacl_bindings.py to generate the bindings
	Mark Seaborn 2014/09/09 19:13:11 "generator" "generator" Nick Bray (chromium) 2014/09/09 23:12:32 Done. Show quoted text On 2014/09/09 19:13:11, Mark Seaborn wrote: > "generator" Done.
	8 that plumb this interface into the NaCl sandbox.

	9

	10 To test: Build "monacl_shell" and "monacl_test". Run monacl_shell

	11 with the IRT as the first argument and the monacl_test as the second

	12 argument. For example, to run a Debug 32-bit Intel build:

	13

	14 cd out/Debug

	15 ./monacl_shell irt_core_newlib_x32.nexe monacl_test_newlib_x32.nexe

OLD	NEW

« mojo/monacl.gyp ('K') | « mojo/monacl/DEPS ('k') | mojo/monacl/generator/NOT_FOR_COMMIT/libmojo.cc » ('j') | mojo/monacl/generator/NOT_FOR_COMMIT/mojo_syscall.cc » ('J')