[Password Manager] Don't prompt to save credentials used to sync passwords

[Password Manager] Don't prompt to save credentials used to sync passwords

TBR=dhollowa@chromium.org
BUG=386402
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282814

[vabr (Chromium), 2014-07-11 08:32:53]

LGTM, Thanks for also updating the internals logs!

Cheers,
Vaclav

https://codereview.chromium.org/385963003/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/385963003/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager_unittest.cc:668:
manager()->OnPasswordFormsParsed(observed);    // The initial load.
optional nit: the comment should either be 2 spaces after the semicolon, or
aligned with the one below.

https://codereview.chromium.org/385963003/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager_unittest.cc:680:
true);  // The post-navigation layout.
optional nit: breaking the code just for having a comment at the end looks ugly;
I suggest putting the comment on its own line before the code, and then add the
code on one line:

// The post-navigation layout.
manager()->OnPasswordFormsRendered(observed, true);

[Garrett Casto, 2014-07-11 21:20:26]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-07-11 21:21:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gcasto@chromium.org/385963003/40001

[commit-bot: I haz the power, 2014-07-12 00:52:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-12 00:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-12 00:54:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Garrett Casto, 2014-07-12 07:05:09]

On 2014/07/12 00:54:50, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

For some reason it thinks that I need approval from dhollowa@ for the changes to
save_password_progress_logger which doesn't make any sense as I'm in the OWNERS
file for components/autofill/* and dhollowa@ isn't. I'll ping someone about this
next week, but in the meantime I'll just TBR him.

[Garrett Casto, 2014-07-12 07:06:08]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-07-12 07:06:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gcasto@chromium.org/385963003/40001

[commit-bot: I haz the power, 2014-07-12 12:45:05]

Change committed as 282814