Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Issue 385963003: [Password Manager] Don't prompt to save credentials used to sync passwords (Closed)

Created:
6 years, 5 months ago by Garrett Casto
Modified:
6 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Don't prompt to save credentials used to sync passwords TBR=dhollowa@chromium.org BUG=386402 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282814

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M components/autofill/core/common/save_password_progress_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 1 2 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Garrett Casto
6 years, 5 months ago (2014-07-11 07:47:33 UTC) #1
vabr (Chromium)
LGTM, Thanks for also updating the internals logs! Cheers, Vaclav https://codereview.chromium.org/385963003/diff/20001/components/password_manager/core/browser/password_manager_unittest.cc File components/password_manager/core/browser/password_manager_unittest.cc (right): https://codereview.chromium.org/385963003/diff/20001/components/password_manager/core/browser/password_manager_unittest.cc#newcode668 ...
6 years, 5 months ago (2014-07-11 08:32:53 UTC) #2
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 5 months ago (2014-07-11 21:20:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/385963003/40001
6 years, 5 months ago (2014-07-11 21:21:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 00:52:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-12 00:54:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79560)
6 years, 5 months ago (2014-07-12 00:54:50 UTC) #7
Garrett Casto
On 2014/07/12 00:54:50, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-12 07:05:09 UTC) #8
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 5 months ago (2014-07-12 07:06:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/385963003/40001
6 years, 5 months ago (2014-07-12 07:06:31 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 12:45:05 UTC) #11
Message was sent while issue was closed.
Change committed as 282814

Powered by Google App Engine
This is Rietveld 408576698