Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 385953003: Revert of WebAudio: Remove AudioNode::RefType. (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of WebAudio: Remove AudioNode::RefType. (https://codereview.chromium.org/349213007/) Reason for revert: Made webaudio/delaynode-max-nondefault-delay.html flaky. Original issue's description: > WebAudio: Remove AudioNode::RefType. > > The motivation of this CL is to reduce manual ref()/deref(). > > AudioNode has two types of ref()/deref(); RefTypeNormal and RefTypeConnection. > It made the code complex, and we couldn't use RefPtr<> for the connection type > references. > > This CL removes AudioNode::RefType. > - m_normalRefCount and m_connectionRefCount were updated independently. After > this CL, connection type references updates both of them. > - We use RefPtr<> for connection type references, and call > AudioNode::makeConnection() and AudioNode::breakConnection() explicitly when > connections are updated. > > BUG=392788 > TEST=none; This CL should not have behavior changes. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177910 NOTRY=true TBR=rtoy@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -95 lines) Patch
M Source/modules/webaudio/AudioBufferSourceNode.h View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/webaudio/AudioNode.h View 2 chunks +8 lines, -13 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 4 chunks +52 lines, -45 lines 0 comments Download
M Source/modules/webaudio/AudioNodeInput.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioNodeOutput.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/webaudio/AudioNodeOutput.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of WebAudio: Remove AudioNode::RefType.
6 years, 5 months ago (2014-07-11 08:56:34 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-11 08:56:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/385953003/1
6 years, 5 months ago (2014-07-11 08:57:09 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 08:57:45 UTC) #4
Message was sent while issue was closed.
Change committed as 177916

Powered by Google App Engine
This is Rietveld 408576698