Chromium Code Reviews
DescriptionRevert of WebAudio: Remove AudioNode::RefType. (https://codereview.chromium.org/349213007/)
Reason for revert:
Made webaudio/delaynode-max-nondefault-delay.html flaky.
Original issue's description:
> WebAudio: Remove AudioNode::RefType.
>
> The motivation of this CL is to reduce manual ref()/deref().
>
> AudioNode has two types of ref()/deref(); RefTypeNormal and RefTypeConnection.
> It made the code complex, and we couldn't use RefPtr<> for the connection type
> references.
>
> This CL removes AudioNode::RefType.
> - m_normalRefCount and m_connectionRefCount were updated independently. After
> this CL, connection type references updates both of them.
> - We use RefPtr<> for connection type references, and call
> AudioNode::makeConnection() and AudioNode::breakConnection() explicitly when
> connections are updated.
>
> BUG=392788
> TEST=none; This CL should not have behavior changes.
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177910
NOTRY=true
TBR=rtoy@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177916
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||