Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385943006: Update speedometer to use results.AddValue() (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
tonyg, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update speedometer to use results.AddValue() BUG=391943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/perf/benchmarks/speedometer.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 5 months ago (2014-07-12 03:18:16 UTC) #1
tonyg
lgtm
6 years, 5 months ago (2014-07-12 16:23:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/385943006/1
6 years, 5 months ago (2014-07-12 16:24:04 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 20:09:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-12 21:18:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170361)
6 years, 5 months ago (2014-07-12 21:18:59 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-12 22:46:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/385943006/1
6 years, 5 months ago (2014-07-12 22:46:26 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-13 01:03:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 282852

Powered by Google App Engine
This is Rietveld 408576698