Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 385943005: Remove WebMediaPlayer::exitFullscreen() (Closed)

Created:
6 years, 5 months ago by qinmin
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, philipj_slow
Project:
blink
Visibility:
Public.

Description

Remove WebMediaPlayer::exitFullscreen() This call is no longer called by any classes, just remove it Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M public/platform/WebMediaPlayer.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
qinmin
PTAL
6 years, 5 months ago (2014-07-12 00:16:05 UTC) #1
trchen
On 2014/07/12 00:16:05, qinmin wrote: > PTAL sweet! lgtm
6 years, 5 months ago (2014-07-12 00:26:58 UTC) #2
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-14 00:37:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/385943005/1
6 years, 5 months ago (2014-07-14 00:38:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-14 01:39:44 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 02:02:47 UTC) #6
Message was sent while issue was closed.
Change committed as 178020

Powered by Google App Engine
This is Rietveld 408576698