Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385943004: Mark the ParseIPLiteralToNumber function as NET_EXPORT because it's used (Closed)

Created:
6 years, 5 months ago by wtc
Modified:
6 years, 5 months ago
Reviewers:
eroman, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mark the ParseIPLiteralToNumber function as NET_EXPORT because it's used by many files outside src/net. R=eroman@chromium.org,mef@chromium.org BUG=393387 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/base/net_util.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
6 years, 5 months ago (2014-07-11 23:59:08 UTC) #1
eroman
lgtm
6 years, 5 months ago (2014-07-12 00:15:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/385943004/1
6 years, 5 months ago (2014-07-12 00:17:49 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 06:20:56 UTC) #4
Message was sent while issue was closed. 
Change committed as 282808

Powered by Google App Engine
This is Rietveld 408576698