Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/browser/extensions/file_reader.cc

Issue 3859003: FBTF: Even more ctor/virtual deinlining. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/file_reader.h" 5 #include "chrome/browser/extensions/file_reader.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "chrome/browser/browser_thread.h" 9 #include "chrome/browser/browser_thread.h"
10 #include "chrome/common/extensions/extension_resource.h" 10 #include "chrome/common/extensions/extension_resource.h"
11 11
12 FileReader::FileReader(const ExtensionResource& resource, Callback* callback) 12 FileReader::FileReader(const ExtensionResource& resource, Callback* callback)
13 : resource_(resource), 13 : resource_(resource),
14 callback_(callback), 14 callback_(callback),
15 origin_loop_(MessageLoop::current()) { 15 origin_loop_(MessageLoop::current()) {
16 DCHECK(callback_); 16 DCHECK(callback_);
17 } 17 }
18 18
19 void FileReader::Start() { 19 void FileReader::Start() {
20 BrowserThread::PostTask( 20 BrowserThread::PostTask(
21 BrowserThread::FILE, FROM_HERE, 21 BrowserThread::FILE, FROM_HERE,
22 NewRunnableMethod(this, &FileReader::ReadFileOnBackgroundThread)); 22 NewRunnableMethod(this, &FileReader::ReadFileOnBackgroundThread));
23 } 23 }
24 24
25 FileReader::~FileReader() {}
26
25 void FileReader::ReadFileOnBackgroundThread() { 27 void FileReader::ReadFileOnBackgroundThread() {
26 std::string data; 28 std::string data;
27 bool success = file_util::ReadFileToString(resource_.GetFilePath(), &data); 29 bool success = file_util::ReadFileToString(resource_.GetFilePath(), &data);
28 origin_loop_->PostTask(FROM_HERE, NewRunnableMethod( 30 origin_loop_->PostTask(FROM_HERE, NewRunnableMethod(
29 this, &FileReader::RunCallback, success, data)); 31 this, &FileReader::RunCallback, success, data));
30 } 32 }
31 33
32 void FileReader::RunCallback(bool success, const std::string& data) { 34 void FileReader::RunCallback(bool success, const std::string& data) {
33 callback_->Run(success, data); 35 callback_->Run(success, data);
34 delete callback_; 36 delete callback_;
35 } 37 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698