Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 385873002: Always build nss_decryptor.cc on Windows and Mac. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Always build nss_decryptor.cc on Windows and Mac. NSS gets dlopen'd on Windows and Mac, so it can be built in the OpenSSL port. BUG=38883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282704

Patch Set 1 #

Total comments: 3

Patch Set 2 : rsleevi comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_utility.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
https://codereview.chromium.org/385873002/diff/1/chrome/chrome_utility.gypi File chrome/chrome_utility.gypi (right): https://codereview.chromium.org/385873002/diff/1/chrome/chrome_utility.gypi#newcode131 chrome/chrome_utility.gypi:131: ['OS!="android"', { For Android, I believe this block already ...
6 years, 5 months ago (2014-07-10 23:48:54 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/385873002/diff/1/chrome/chrome_utility.gypi File chrome/chrome_utility.gypi (left): https://codereview.chromium.org/385873002/diff/1/chrome/chrome_utility.gypi#oldcode124 chrome/chrome_utility.gypi:124: 'utility/importer/nss_decryptor.cc', Don't we still want to include this if ...
6 years, 5 months ago (2014-07-11 01:05:34 UTC) #2
davidben
https://codereview.chromium.org/385873002/diff/1/chrome/chrome_utility.gypi File chrome/chrome_utility.gypi (left): https://codereview.chromium.org/385873002/diff/1/chrome/chrome_utility.gypi#oldcode124 chrome/chrome_utility.gypi:124: 'utility/importer/nss_decryptor.cc', On 2014/07/11 01:05:33, Ryan Sleevi wrote: > Don't ...
6 years, 5 months ago (2014-07-11 13:50:50 UTC) #3
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-11 20:46:46 UTC) #4
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-11 20:49:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/385873002/20001
6 years, 5 months ago (2014-07-11 20:51:30 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 21:37:19 UTC) #7
Message was sent while issue was closed.
Change committed as 282704

Powered by Google App Engine
This is Rietveld 408576698