Update page_cycler to use results.AddValue(...).

tools/perf/measurements/page_cycler.py

Index: tools/perf/measurements/page_cycler.py
diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py
index babf272f39b8b21f85ab13c5ac4ab891f07d4759..dd4050fb19bf1c91b33006a331679b8128d80712 100644
--- a/tools/perf/measurements/page_cycler.py
+++ b/tools/perf/measurements/page_cycler.py
@@ -26,6 +26,8 @@ from metrics import speedindex
 from metrics import v8_object_stats
 from telemetry.core import util
 from telemetry.page import page_measurement
+from telemetry.value import scalar
+
 
 class PageCycler(page_measurement.PageMeasurement):
   options = {'pageset_repeat': 10}
@@ -128,9 +130,9 @@ class PageCycler(page_measurement.PageMeasurement):
     chart_name_prefix = ('cold_' if self.IsRunCold(page.url) else
                          'warm_')
 
-    results.Add('page_load_time', 'ms',
-                int(float(tab.EvaluateJavaScript('__pc_load_time'))),
-                chart_name=chart_name_prefix+'times')
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, '%stimes.page_load_time' % chart_name_prefix,
+        'ms', int(float(tab.EvaluateJavaScript('__pc_load_time')))))

[tonyg, 2014/07/11 02:12:16]

Not sure, but can we get rid of the int(float()) thing now?

[nednguyen, 2014/07/11 03:10:39]

Done.

 
     self._has_loaded_page[page.url] += 1