Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 385753002: [chromedriver] Generate mobile devices list from OverridesUI.js. (Closed)

Created:
6 years, 5 months ago by samuong
Modified:
6 years, 5 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Generate mobile devices list from OverridesUI.js. BUG=chromedriver:843 TBR=stgao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/embed_mobile_devices_in_cpp.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 5 months ago (2014-07-10 20:40:25 UTC) #1
samuong
The CQ bit was unchecked by samuong@chromium.org
6 years, 5 months ago (2014-07-10 20:41:23 UTC) #2
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 5 months ago (2014-07-10 20:41:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/385753002/1
6 years, 5 months ago (2014-07-10 20:42:41 UTC) #4
commit-bot: I haz the power
Change committed as 282477
6 years, 5 months ago (2014-07-11 00:14:09 UTC) #5
stgao
6 years, 5 months ago (2014-07-11 01:36:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698