Issue 385733002: Make KillAllAdb robust to AccessDenied exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385733002: Make KillAllAdb robust to AccessDenied exceptions. (Closed)

Created:
6 years, 5 months ago by tonyg

Modified:
6 years, 5 months ago

Reviewers:
navabi1, Yaron, navabi, frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Make KillAllAdb robust to AccessDenied exceptions. This error seems to pop up when adb is not currently running. It isn't clear to me why we get that instead of NoSuchProcess, but in any case, this should allow us to continue instead of aborting like in: http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1022/steps/device_status_check/logs/stdio BUG=388885 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282525

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/android/buildbot/bb_device_status_check.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/385733002/1

6 years, 5 months ago (2014-07-11 00:35:17 UTC) #4

Message was sent while issue was closed.

lgtm