chrome/renderer/resources/extensions/binding.js - Issue 38573008: Add "platforms" key in IDL schema compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/binding.js

Issue 38573008: Add "platforms" key in IDL schema compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/binding.js

diff --git a/chrome/renderer/resources/extensions/binding.js b/chrome/renderer/resources/extensions/binding.js

index 4bb9b99bfbdece26a428b09c1b9b5ed391275adb..cc38da81044ff5ccc0d58d30d2b6b60c714b933a 100644

--- a/chrome/renderer/resources/extensions/binding.js

+++ b/chrome/renderer/resources/extensions/binding.js

@@ -114,7 +114,7 @@ function getPlatform() {

}

function isPlatformSupported(schemaNode, platform) {

- return !schemaNode.platforms ||

+ return !schemaNode.platforms || schemaNode.platforms.length == 0 ||

not at google - send to devlin 2013/10/25 17:00:08 if something specificies "platforms: []" then it s

Haojian Wu 2013/10/26 03:15:51 Done.

schemaNode.platforms.indexOf(platform) > -1;

}