tools/json_schema_compiler/model.py - Issue 38573008: Add "platforms" key in IDL schema compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/model.py

Issue 38573008: Add "platforms" key in IDL schema compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/model.py

diff --git a/tools/json_schema_compiler/model.py b/tools/json_schema_compiler/model.py

index cc876dfad77730e9d72eaad52c73fff75b63fdf3..336563c6cfe8499d77942cffe3775ae7b3a707bd 100644

--- a/tools/json_schema_compiler/model.py

+++ b/tools/json_schema_compiler/model.py

@@ -486,8 +486,11 @@ class Platforms(object):

WIN = _PlatformInfo("win")

def _GetPlatforms(json):

- if 'platforms' not in json:

+ if 'platforms' not in json or json['platforms'] == None:

return None

+ # Check whether "platforms" is an empty list.

not at google - send to devlin 2013/10/29 14:36:52 More accurate would be to say "Sanity check: platf

Haojian Wu 2013/10/30 00:42:47 Done.

+ if not json['platforms']:

+ raise ValueError('"platforms" cannot be an empty list')

platforms = []

for platform_name in json['platforms']:

for platform_enum in _Enum.GetAll(Platforms):