Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/json_schema_compiler/model.py

Issue 38573008: Add "platforms" key in IDL schema compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment issues Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/model.py
diff --git a/tools/json_schema_compiler/model.py b/tools/json_schema_compiler/model.py
index cc876dfad77730e9d72eaad52c73fff75b63fdf3..6e5ec55fade85cc21362628b6850c87411a5f3d0 100644
--- a/tools/json_schema_compiler/model.py
+++ b/tools/json_schema_compiler/model.py
@@ -486,7 +486,7 @@ class Platforms(object):
WIN = _PlatformInfo("win")
def _GetPlatforms(json):
- if 'platforms' not in json:
+ if 'platforms' not in json or not json['platforms']:
not at google - send to devlin 2013/10/28 17:04:48 if "platforms" can't be empty then this change doe
Haojian Wu 2013/10/29 02:09:32 The statement "not json['platforms']"'s aim is to
not at google - send to devlin 2013/10/29 14:36:52 How is platforms None? There are three false state
Haojian Wu 2013/10/30 00:42:47 The third false states: platforms set to None, the
return None
platforms = []
for platform_name in json['platforms']:

Powered by Google App Engine
This is Rietveld 408576698