Web Animations CSS: Fix crash when transitioning background or mask properties

Source/core/rendering/style/FillLayer.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 22 matching lines @@
     Length m_yPosition;
 
     LengthSize m_sizeLength;
 
     unsigned m_bitfields: 32;
     unsigned m_bitfields2: 1;
 };
 
 COMPILE_ASSERT(sizeof(FillLayer) == sizeof(SameSizeAsFillLayer), FillLayer_should_stay_small);
 
-FillLayer::FillLayer(EFillLayerType type)
+FillLayer::FillLayer(EFillLayerType type, bool isInitiallySet)

[Steve Block, 2013/11/03 10:16:48]

Would something like useInitialSize be a better name? This seems like an
instruction about initialization, but the name sounds like a current state.

[alancutter (OOO until 2018), 2013/11/04 00:45:24]

Renamed to useInitialValues.

     : m_next(0)
     , m_image(FillLayer::initialFillImage(type))
     , m_xPosition(FillLayer::initialFillXPosition(type))
     , m_yPosition(FillLayer::initialFillYPosition(type))
     , m_sizeLength(FillLayer::initialFillSizeLength(type))
     , m_attachment(FillLayer::initialFillAttachment(type))
     , m_clip(FillLayer::initialFillClip(type))
     , m_origin(FillLayer::initialFillOrigin(type))
     , m_repeatX(FillLayer::initialFillRepeatX(type))
     , m_repeatY(FillLayer::initialFillRepeatY(type))
     , m_composite(FillLayer::initialFillComposite(type))
-    , m_sizeType(SizeNone) // SizeNone indicates size is unset.
+    , m_sizeType(isInitiallySet ? FillLayer::initialFillSizeType(type) : SizeNone)
     , m_blendMode(FillLayer::initialFillBlendMode(type))
     , m_maskSourceType(FillLayer::initialFillMaskSourceType(type))
     , m_backgroundXOrigin(LeftEdge)
     , m_backgroundYOrigin(TopEdge)
-    , m_imageSet(false)
-    , m_attachmentSet(false)
-    , m_clipSet(false)
-    , m_originSet(false)
-    , m_repeatXSet(false)
-    , m_repeatYSet(false)
-    , m_xPosSet(false)
-    , m_yPosSet(false)
-    , m_backgroundXOriginSet(false)
-    , m_backgroundYOriginSet(false)
-    , m_compositeSet(type == MaskFillLayer)
-    , m_blendModeSet(false)
-    , m_maskSourceTypeSet(false)
+    , m_imageSet(isInitiallySet)
+    , m_attachmentSet(isInitiallySet)
+    , m_clipSet(isInitiallySet)
+    , m_originSet(isInitiallySet)
+    , m_repeatXSet(isInitiallySet)
+    , m_repeatYSet(isInitiallySet)
+    , m_xPosSet(isInitiallySet)
+    , m_yPosSet(isInitiallySet)
+    , m_backgroundXOriginSet(isInitiallySet)
+    , m_backgroundYOriginSet(isInitiallySet)
+    , m_compositeSet(isInitiallySet || type == MaskFillLayer)
+    , m_blendModeSet(isInitiallySet)
+    , m_maskSourceTypeSet(isInitiallySet)
     , m_type(type)
 {
 }
 
 FillLayer::FillLayer(const FillLayer& o)
     : m_next(o.m_next ? new FillLayer(*o.m_next) : 0)
     , m_image(o.m_image)
     , m_xPosition(o.m_xPosition)
     , m_yPosition(o.m_yPosition)
     , m_sizeLength(o.m_sizeLength)
@@ skipping 286 matching lines @@
 
     return false;
 }
 
 bool FillLayer::hasRepeatXY() const
 {
     return m_repeatX == RepeatFill && m_repeatY == RepeatFill;
 }
 
 } // namespace WebCore