Fix build dependencies on target remoting_webapp_unittest

Fix build dependencies on target remoting_webapp_unittest

There is a typo in the output element of the "Build Remoting Webapp unittest.html" action.  The current output element refers to a non-existent location.  As a result, ninja invoke the action on every build run.

I also removes exclude-js from the input element, as there is no need to re-invoke the action if the content of an excluded script is modified.

BUG=392834
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282486

[kelvinp, 2014-07-10 20:13:35]

PTAL

[Nico, 2014-07-10 20:20:20]

Thanks!

https://codereview.chromium.org/385713003/diff/20001/remoting/remoting_test.gypi
File remoting/remoting_test.gypi (right):

https://codereview.chromium.org/385713003/diff/20001/remoting/remoting_test.g...
remoting/remoting_test.gypi:356: '<(output_dir)/unittest.html',
There are two possible patterns to avoid having to repeat this in both the
outputs block and the actual action (which is what made this bug possible):

1.) Write "_outputs" in the action block; it'll be replaced with the contents of
the outputs block. Examples:
https://code.google.com/p/chromium/codesearch#search/&q=_outputs%20file:gyp&s...

2.) Have a variables block where you define a variable (e.g. named output_file,
but the name is up to you), and then reference that in outputs and action. One
example for this is
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/dex_...

[Nico, 2014-07-10 20:37:25]

lgtm

[garykac, 2014-07-10 20:38:12]

https://codereview.chromium.org/385713003/diff/40001/remoting/remoting_test.gypi
File remoting/remoting_test.gypi (left):

https://codereview.chromium.org/385713003/diff/40001/remoting/remoting_test.g...
remoting/remoting_test.gypi:353: '<@(remoting_webapp_unittest_exclude_files)',
I assume that removing this is unrelated to the change to fix the empty build
run...

[kelvinp, 2014-07-10 20:56:48]

https://codereview.chromium.org/385713003/diff/40001/remoting/remoting_test.gypi
File remoting/remoting_test.gypi (left):

https://codereview.chromium.org/385713003/diff/40001/remoting/remoting_test.g...
remoting/remoting_test.gypi:353: '<@(remoting_webapp_unittest_exclude_files)',
On 2014/07/10 20:38:12, garykac wrote:
> I assume that removing this is unrelated to the change to fix the empty build
> run...

Yup, maybe should rename the change as fix build dependencies on remoting webapp
unittest.  
The exclude files should not be part of the input.  As if the user changes the
content of an excluded file, we should not rebuild the test page.

[garykac, 2014-07-10 22:08:39]

On 2014/07/10 20:56:48, kelvinp wrote:
>
https://codereview.chromium.org/385713003/diff/40001/remoting/remoting_test.gypi
> File remoting/remoting_test.gypi (left):
> 
>
https://codereview.chromium.org/385713003/diff/40001/remoting/remoting_test.g...
> remoting/remoting_test.gypi:353: '<@(remoting_webapp_unittest_exclude_files)',
> On 2014/07/10 20:38:12, garykac wrote:
> > I assume that removing this is unrelated to the change to fix the empty
build
> > run...
> 
> Yup, maybe should rename the change as fix build dependencies on remoting
webapp
> unittest.  
> The exclude files should not be part of the input.  As if the user changes the
> content of an excluded file, we should not rebuild the test page.

lgtm once the description has been updated.

[kelvinp, 2014-07-10 22:32:53]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2014-07-10 22:33:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kelvinp@chromium.org/385713003/40001

[commit-bot: I haz the power, 2014-07-11 01:07:48]

Change committed as 282486