Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 3857001: Work around sigaltstack() bug on Mac OS X when unregistering a signal stack (Closed)

Created:
10 years, 2 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
Cliff L. Biffle
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Work around sigaltstack() bug on Mac OS X when unregistering a signal stack This bug manifests itself when building with "-mmacosx-version-min=10.5", which is necessary in order to build sel_ldr for x86-64 but which causes a newer version of libc's sigaltstack() wrapper to be used. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1051 BUG=http://code.google.com/p/nativeclient/issues/detail?id=1053 TEST=run_hello_world_test when SConstruct is changed to use "-mmacosx-version-min=10.5" instead of 10.4 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=3504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/native_client/src/trusted/service_runtime/posix/nacl_signal.c View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
I guess we should ignore, for now, the problem that signal handlers on Mac won't ...
10 years, 2 months ago (2010-10-17 19:46:25 UTC) #1
Mark Seaborn
Cliff wrote: > Well, Rietveld is totally hosed for me right now (getting JavaScript > ...
10 years, 2 months ago (2010-10-18 19:40:44 UTC) #2
Cliff L. Biffle
10 years, 2 months ago (2010-10-19 21:25:26 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698