copy gs_utils.py from skia repo into common repo

copy gs_utils.py from skia repo into common repo

BUG=skia:2618
R=borenet@google.com

Committed: https://skia.googlesource.com/common/+/6f68dfa

[epoger, 2014-07-10 17:27:40]

Eric- Please see patchset 1.  This isn't going to work as-is; any ideas?

https://codereview.chromium.org/385673002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/385673002/diff/1/DEPS#newcode3
DEPS:3: # Dependencies on outside packages.
I'm not sure how we should handle these transitive dependencies for code within
the common repo.

We don't fetch DEPS of the common repo, so this won't work as-is.  Do we need to
mandate that any repo which uses common provides these dependencies?

Or maybe that's just too complicated, and any utility module that requires its
own dependencies should not live in the common repo?

https://codereview.chromium.org/385673002/diff/1/py/utils/gs_utils.py
File py/utils/gs_utils.py (right):

https://codereview.chromium.org/385673002/diff/1/py/utils/gs_utils.py#newcode18
py/utils/gs_utils.py:18: TRUNK_DIRECTORY = os.path.abspath(os.path.join(
This refers to the root directory of the common repo checkout, so if the
transitive dependencies go somewhere else, we will need to change it.

https://codereview.chromium.org/385673002/diff/1/py/utils/gs_utils.py#newcode24
py/utils/gs_utils.py:24: print 'EPOGER %s' % import_dirpath
Note to self: delete this line in the next patchset.

[epoger, 2014-07-10 17:53:40]

Notes about "gclient sync" recursively fetching dependencies:

http://www.chromium.org/developers/how-tos/chromium-modularization says:
"Given that dependencies are not computed recursively..." (and refers to the
From keyword, which allows you to inherit the *revision* of a dependency from
another DEPS file)

https://groups.google.com/a/google.com/forum/#!searchin/chrome-infrastructure...
mentions a "recursion = 2" instruction you can add to the outermost DEPS file;
this was apparently added in https://codereview.chromium.org/11146032/

Looking at https://src.chromium.org/svn/trunk/tools/depot_tools/gclient.py ,
that seems to still be supported.

My proposal:
1. I commit this CL
2. I work on a change to the skia repo that pulls it in using "recursion = 2"

WDYT?

[borenet, 2014-07-10 18:06:16]

LGTM with a couple of questions.

https://codereview.chromium.org/385673002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/385673002/diff/20001/DEPS#newcode18
DEPS:18: #]
Why do we need this?

https://codereview.chromium.org/385673002/diff/20001/py/utils/gs_utils.py
File py/utils/gs_utils.py (right):

https://codereview.chromium.org/385673002/diff/20001/py/utils/gs_utils.py#new...
py/utils/gs_utils.py:1: #!/usr/bin/python
I guess this is pure copy/paste?

[epoger, 2014-07-10 18:17:40]

Committing now...

https://codereview.chromium.org/385673002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/385673002/diff/20001/DEPS#newcode18
DEPS:18: #]
On 2014/07/10 18:06:16, borenet wrote:
> Why do we need this?

We don't.  I just copied it in from the skia repo's DEPS file.  Deleted.

https://codereview.chromium.org/385673002/diff/20001/py/utils/gs_utils.py
File py/utils/gs_utils.py (right):

https://codereview.chromium.org/385673002/diff/20001/py/utils/gs_utils.py#new...
py/utils/gs_utils.py:1: #!/usr/bin/python
On 2014/07/10 18:06:16, borenet wrote:
> I guess this is pure copy/paste?

Yup, sorry, copied over from
https://skia.googlesource.com/skia/+/master/tools/pyutils/gs_utils.py , with a
few minor modifications in the import/sys.path stuff.

[epoger, 2014-07-10 18:17:49]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-07-10 18:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 18:18:34]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[rmistry, 2014-07-10 18:19:04]

On 2014/07/10 18:18:34, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Right, no CQ for this yet, its on my list.

[epoger, 2014-07-10 18:25:36]

Committed patchset #3 manually as r6f68dfa (presubmit successful).