Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(63)

Issue 385673002: copy gs_utils.py from skia repo into common repo (Closed)

Created:
4 years, 11 months ago by epoger
Modified:
4 years, 11 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

copy gs_utils.py from skia repo into common repo BUG=skia:2618 R=borenet@google.com Committed: https://skia.googlesource.com/common/+/6f68dfa

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove debug line #

Total comments: 4

Patch Set 3 : Eric comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -0 lines) Patch
A DEPS View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A py/utils/gs_utils.py View 1 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/externals/README View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
epoger
Eric- Please see patchset 1. This isn't going to work as-is; any ideas? https://codereview.chromium.org/385673002/diff/1/DEPS File ...
4 years, 11 months ago (2014-07-10 17:27:40 UTC) #1
epoger
Notes about "gclient sync" recursively fetching dependencies: http://www.chromium.org/developers/how-tos/chromium-modularization says: "Given that dependencies are not computed ...
4 years, 11 months ago (2014-07-10 17:53:40 UTC) #2
borenet
LGTM with a couple of questions. https://codereview.chromium.org/385673002/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/385673002/diff/20001/DEPS#newcode18 DEPS:18: #] Why do ...
4 years, 11 months ago (2014-07-10 18:06:16 UTC) #3
epoger
Committing now... https://codereview.chromium.org/385673002/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/385673002/diff/20001/DEPS#newcode18 DEPS:18: #] On 2014/07/10 18:06:16, borenet wrote: > ...
4 years, 11 months ago (2014-07-10 18:17:40 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
4 years, 11 months ago (2014-07-10 18:17:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 11 months ago (2014-07-10 18:18:32 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
4 years, 11 months ago (2014-07-10 18:18:34 UTC) #7
rmistry
On 2014/07/10 18:18:34, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
4 years, 11 months ago (2014-07-10 18:19:04 UTC) #8
epoger
4 years, 11 months ago (2014-07-10 18:25:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r6f68dfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698