Issue 385643002: [Android] Clean up ViewAndroid and WindowAndroid checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385643002: [Android] Clean up ViewAndroid and WindowAndroid checks (Closed)

Created:
6 years, 5 months ago by boliu

Modified:
6 years, 5 months ago

Reviewers:
jdduke (slow), Yaron, aurimas (slooooooooow)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Clean up ViewAndroid and WindowAndroid checks These are not null everywhere now, including android webview. Remove obsolete conditionals and comments, and add asserts. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282421

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -15 lines)			Patch
	M	content/browser/android/content_view_core_impl.cc	View		3 chunks	+4 lines, -8 lines	0 comments	Download
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

LGTM, but please wait for yfriedman's review

6 years, 5 months ago (2014-07-10 17:10:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/385643002/1

6 years, 5 months ago (2014-07-10 18:34:20 UTC) #5

Message was sent while issue was closed.

Change committed as 282421

Expand Messages | Collapse Messages