Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385633002: UserManager refactoring: move active user session restoration to UserSessionManager. (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

UserManager refactoring: move active user session restoration to UserSessionManager. Extracted UserSessionManager::Delegate as UserSessionManagerDelegate. Added UserSessionStateDelegate which will for now coexist with UserManager::UserSessionStateDelegate till latter will be deprecated and merged with the former. BUG=387614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -211 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 9 chunks +79 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 9 chunks +145 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager.h View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.h View 10 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 7 chunks +0 lines, -106 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nikita (slow)
6 years, 5 months ago (2014-07-10 16:29:42 UTC) #1
antrim
lgtm
6 years, 5 months ago (2014-07-10 16:32:08 UTC) #2
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-10 16:33:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/385633002/1
6 years, 5 months ago (2014-07-10 16:34:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 20:12:35 UTC) #5
Message was sent while issue was closed. 
Change committed as 282411

Powered by Google App Engine
This is Rietveld 408576698