Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 385613003: Fix an issue with an upcoming webrtc roll where the 'name' property of StatsReport::Value is const. (Closed)

Created:
6 years, 5 months ago by tommi (sloooow) - chröme
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix an issue with an upcoming webrtc roll where the 'name' property of StatsReport::Value is const. TBR=grunell NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282432

Patch Set 1 #

Patch Set 2 : Pick a more future proof value name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M content/renderer/media/mock_peer_connection_impl.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tommi (sloooow) - chröme
6 years, 5 months ago (2014-07-10 15:00:36 UTC) #1
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 5 months ago (2014-07-10 15:03:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/385613003/1
6 years, 5 months ago (2014-07-10 15:03:33 UTC) #3
Henrik Grunell
lgtm
6 years, 5 months ago (2014-07-10 15:26:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 16:58:07 UTC) #5
tommi (sloooow) - chröme
Pick a more future proof value name
6 years, 5 months ago (2014-07-10 17:48:12 UTC) #6
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 5 months ago (2014-07-10 17:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/385613003/20001
6 years, 5 months ago (2014-07-10 17:50:33 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 19:38:32 UTC) #9
tommi (sloooow) - chröme
The CQ bit was unchecked by tommi@chromium.org
6 years, 5 months ago (2014-07-10 21:29:11 UTC) #10
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 5 months ago (2014-07-10 21:29:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/385613003/20001
6 years, 5 months ago (2014-07-10 21:30:15 UTC) #12
commit-bot: I haz the power
Change committed as 282432
6 years, 5 months ago (2014-07-10 21:38:38 UTC) #13
vivekg
6 years, 5 months ago (2014-07-21 09:48:56 UTC) #14
Message was sent while issue was closed.
On 2014/07/10 21:38:38, I haz the power (commit-bot) wrote:
> Change committed as 282432

This change breaks non-clang builds on ubuntu 12.04 using gcc 4.6.4 
The error is as follows:

../../content/renderer/media/mock_peer_connection_impl.cc: In member function
‘virtual bool content::MockPeerConnectionImpl::GetStats(webrtc::StatsObserver*,
webrtc::MediaStreamTrackInterface*,
webrtc::PeerConnectionInterface::StatsOutputLevel)’:
../../content/renderer/media/mock_peer_connection_impl.cc:280:3: error: in C++98
‘value’ must be initialized by constructor, not by ‘{...}’
../../content/renderer/media/mock_peer_connection_impl.cc:293:5: error: in C++98
‘value2’ must be initialized by constructor, not by ‘{...}’

Powered by Google App Engine
This is Rietveld 408576698