Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 385603002: IDL: Support using nullable on any method return type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use_result_local => use_local_result Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index dbcd013375241d57a6034168c3eae62c1d9f28c9..b3de551a046925d0934b46b7fc82b22bae4b2bcc 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -721,3 +721,17 @@ def literal_cpp_value(idl_type, idl_literal):
return literal_value
IdlType.literal_cpp_value = literal_cpp_value
+
+
+def is_nullable_simple(idl_type):
+ # Nullable type where the corresponding C++ type supports a null value.
+ # - String types (String/AtomicString) represent null as a null string,
+ # i.e. one for which String::isNull() returns true.
+ # - Wrapper types (raw pointer or RefPtr/PassRefPtr) represent null as
+ # a null pointer.
+ return idl_type.is_nullable and (
+ (idl_type.is_string_type or idl_type.is_wrapper_type) and
+ not idl_type.native_array_element_type)
+
+IdlType.is_nullable_simple = property(is_nullable_simple)
+IdlUnionType.is_nullable_simple = False
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698