Source/bindings/scripts/idl_definitions.py - Issue 385603002: IDL: Support using nullable on any method return type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_definitions.py

Issue 385603002: IDL: Support using nullable on any method return type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use_result_local => use_local_result Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_definitions.py

diff --git a/Source/bindings/scripts/idl_definitions.py b/Source/bindings/scripts/idl_definitions.py

index 75900355eca89100fba24d90c8022954f5674d3f..ab3b0c500df1f67c40d8160de7fa0c2a832dface 100644

--- a/Source/bindings/scripts/idl_definitions.py

+++ b/Source/bindings/scripts/idl_definitions.py

@@ -769,7 +769,8 @@ def type_node_inner_to_type(node, is_array=False, is_nullable=False):

elif node_class == 'Sequence':

if is_array:

raise ValueError('Arrays of sequences are not supported')

- return sequence_node_to_type(node, is_nullable=is_nullable)

+ sequence_is_nullable = node.GetProperty('NULLABLE') or False

+ return sequence_node_to_type(node, is_nullable=sequence_is_nullable)

elif node_class == 'UnionType':

if is_array:

raise ValueError('Arrays of unions are not supported')

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »