Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 385593002: Oilpan: trace MediaControlElement's element reference. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: trace MediaControlElement's element reference. R=ager@chromium.org,haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M Source/core/html/shadow/MediaControlElementTypes.h View 3 chunks +7 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-10 14:28:00 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-10 14:32:03 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 5 months ago (2014-07-10 14:32:17 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-10 15:12:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/385593002/1
6 years, 5 months ago (2014-07-10 15:13:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-10 16:21:26 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 17:30:54 UTC) #7
Message was sent while issue was closed.
Change committed as 177858

Powered by Google App Engine
This is Rietveld 408576698